Logo

[OpenITG] DDR Party Collection - need help! (56k!)

Register Log In Back To Forums

Post #1 · Posted at 2014-04-10 01:45:02am 8.2 years ago

Offline Wan
Wan Avatar Member
389 Posts
Chile
Reg. 2008-01-13
Log in to send this user a private messageTwitter: WannyTiggah
Steam: WannyTiggah
"I want to change my username =("

Last updated: 2014-04-10 02:03am
Well, this has been a looong running project of mine, and I'm still tweaking various aspects of it from time to time.
It's almost a direct copy of Takuya's Party Collection theme for 3.9, with some elements borrowed from Beware Extreme and many others implemented by me.

Screenshot spamfest incoming!

http://i.imgur.com/PaihY3B.jpg
Yay home screen. The "yellow" text is the actually highlighted, so it changes when moving the cursor. Takuya's theme didn't for technical reasons.
I've yet to make an INFORMATION screen.

http://i.imgur.com/xoWoV4C.jpg
Separate parts for the platform and character are used. From Takuya's theme, if one starts in the 2P side, a different character appears.
Also, the stage count changes dinamically.

http://i.imgur.com/VSYgBIV.jpg
Difficulty Selection screen. I NEED HELP HERE (explained below).

http://i.imgur.com/sr52Wum.jpg
In 4:3 mode this looks fine, but there's too much space in widescreen modes. I might change the elements position to a proportion of the screen instead of SCREEN_LEFT+something.
If you notice, Random and Roulette are in their correct positions. Any OpenITG build later than August 2011 allows this via metrics.
Also, I'm using the Sort Series image. It's in the original game data but never used (there's no group sort in Party Collection)

http://i.imgur.com/6SMcWsg.jpg
Original options, original font ripped from the game and arranged by hand. To not show the difficulty number in the list, any OpenITG build later than August 2011 is needed (changed via metrics).
I've yet to find a way to make the OptionIcons change when selecting options like in the original game.

http://i.imgur.com/NXyesKD.jpg
Elements adapt to the screen size, except the life bar. Didn't want to stretch it.
The shown options are like in the original game.

http://i.imgur.com/fAoFZV0.jpg
Score is normal instead of percentage. Planning to change it.

http://i.imgur.com/4potZ0x.jpg
http://i.imgur.com/J0tXuin.jpg
Heavily customized Operator Menu, with corresponding sounds and whatnot

http://i.imgur.com/ydGkl24.jpg
PS2 ending video. The audio changes in December like in the original game.

_______________________________________________________________________________________________

Now, I need help with the Difficulty selection screen. The screen uses Takuya's method so ScreenSelectMaster is used.
- First of all, if I pick either Nonstop or Challenge, the game crashes with an Access Violation. This happens from SM 3.95 onwards.
- The cursors behave weirdly. For example, if both players start in Beginner and Player 1 moves to Light, when Player 2 then moves to the right it SKIPS Player 1's cursor and goes straight to Standard. If Player 2 moves back to the left it lands on Light as it should.


[Come to think, I started working on this when Takuya was actively theming, so I asked himself permission to port the theme...]

Post #2 · Posted at 2014-04-10 02:34:08pm 8.2 years ago

Offline Mad Matt
Mad Matt Avatar Member
65 Posts
United States
Reg. 2011-10-26
Log in to send this user a private message
Quote: Wan
To not show the difficulty number in the list, any OpenITG build later than August 2011 is needed.
This is not strictly true. In normal 3.95 it is possible to override the text of any option row, although it has to be done in a difficult and convoluted way.

Quote: Wan
Now, I need help with the Difficulty selection screen. The screen uses Takuya's method so ScreenSelectMaster is used.
- First of all, if I pick either Nonstop or Challenge, the game crashes with an Access Violation. This happens from SM 3.95 onwards.
- The cursors behave weirdly. For example, if both players start in Beginner and Player 1 moves to Light, when Player 2 then moves to the right it SKIPS Player 1's cursor and goes straight to Standard. If Player 2 moves back to the left it lands on Light as it should.
If you want to send me a copy of the theme I can try to figure this out for you. Without seeing the code I can't offer much help.

Post #3 · Posted at 2014-04-10 04:42:06pm 8.2 years ago

Offline Th3_Ov3rHell_3XoduZ
Th3_Ov3rHell_3XoduZ Avatar Member
313 Posts
Chile
Reg. 2012-09-13
Log in to send this user a private messageSkype: Th3_Ov3rHell_3XoduZFacebookTwitter: @Ov3rHell3XoduZYouTube
PlayStation Network: Ov3rHell3XoduZSteam: Ov3rHell3XoduZ
"ITG, The Best Dance Machine!"
Well I am not able to help so much, I'm user of SM5 but I have to say it looks WOW
Quote: Released Themes for SM5 Beta 3
Quote: Released Themes for SM5 Beta 4 & 5.0.7
Quote: Simfles Packs Released

Post #4 · Posted at 2014-04-10 07:23:50pm 8.2 years ago

Offline Wan
Wan Avatar Member
389 Posts
Chile
Reg. 2008-01-13
Log in to send this user a private messageTwitter: WannyTiggah
Steam: WannyTiggah
"I want to change my username =("
Quote: Mad Matt
Quote: Wan
To not show the difficulty number in the list, any OpenITG build later than August 2011 is needed.
This is not strictly true. In normal 3.95 it is possible to override the text of any option row, although it has to be done in a difficult and convoluted way.

Quote: Wan
Now, I need help with the Difficulty selection screen. The screen uses Takuya's method so ScreenSelectMaster is used.
- First of all, if I pick either Nonstop or Challenge, the game crashes with an Access Violation. This happens from SM 3.95 onwards.
- The cursors behave weirdly. For example, if both players start in Beginner and Player 1 moves to Light, when Player 2 then moves to the right it SKIPS Player 1's cursor and goes straight to Standard. If Player 2 moves back to the left it lands on Light as it should.
If you want to send me a copy of the theme I can try to figure this out for you. Without seeing the code I can't offer much help.
Here you go, I didn't include the ending video for now (it's 127 MB big):

http://www.mediafire.com/download/wb3xj2ep7p95kfv/Parti_colekshon.7z

Post #5 · Posted at 2014-04-10 10:59:23pm 8.2 years ago

Offline Mad Matt
Mad Matt Avatar Member
65 Posts
United States
Reg. 2011-10-26
Log in to send this user a private message

Last updated: 2014-04-10 11:20pm
The crashing when you make a selection on page 2 is caused by the "DoMenuStart" function in the code for ScreenSelectMaster, lines 644 to 679.

On page 2, or on page1 if SharePreviewAndCursor are turned on, it'll call that function for both players when you hit start.
When it calls the function for player 1, "bIsFirstToChoose" is false so it doesn't do much.
The second time around, it'll run through the conditional starting on line 661.
If SharePreviewAndCursor is false, as it is in your case, it'll try to run CursorPart1P2ChooseCommand, regardless of which players are enabled.
If only player 1 is enabled, this will cause an Access Violation. If only player 2 is enable, or both players are enabled, it will not crash here.

The only real way around this is to turn on SharePreviewAndCursor conditionally. The caveat is that you'll have to make all of the shared cursor and preview parts look identical to the P1 cursor and preview parts, because with only P1, it'll use those instead.

I'll look at the cursor jumping part later.

edit: It's actually the "GetTimeLeftInTween" that causes the crash, not the command.

Post #6 · Posted at 2014-04-11 12:17:32am 8.2 years ago

Offline Wan
Wan Avatar Member
389 Posts
Chile
Reg. 2008-01-13
Log in to send this user a private messageTwitter: WannyTiggah
Steam: WannyTiggah
"I want to change my username =("
Could it probably be fixed directly in the source? The metrics from ScreenSelectMaster are identical as in the 3.9 theme, and it didn't crash there.

Post #7 · Posted at 2014-04-11 12:26:33am 8.2 years ago

Offline Mad Matt
Mad Matt Avatar Member
65 Posts
United States
Reg. 2011-10-26
Log in to send this user a private message
Sure, just throw a "if(m_sprCursor[i][iIndex] != NULL)" in there before it tries to check the remaining tween time.

Post #8 · Posted at 2014-04-11 01:26:28am 8.2 years ago

Offline Wan
Wan Avatar Member
389 Posts
Chile
Reg. 2008-01-13
Log in to send this user a private messageTwitter: WannyTiggah
Steam: WannyTiggah
"I want to change my username =("

Last updated: 2014-04-11 01:37am
Quote: Mad Matt
Sure, just throw a "if(m_sprCursor[i][iIndex] != NULL)" in there before it tries to check the remaining tween time.
Let's see how this goes. Starting VS now.

EDIT:
Quote
Find all "GetTimeLeftInTween", Subfolders, Find Results 1, "Entire Solution"
Matching lines: 0 Matching files: 0 Total files searched: 1366

EDIT2:

It's actually GetTweenTimeLeft. So, you mean to leave it like this?

Quote
for( int i=0; i<NUM_CURSOR_PARTS; i++ )
{
COMMAND( m_sprCursor[i][pn], "Choose");
if(m_sprCursor[i][iIndex] != NULL)
{
fSecs = max( fSecs, m_sprCursor[i][iIndex]->GetTweenTimeLeft() );
}
}

Post #9 · Posted at 2014-04-11 01:35:12am 8.2 years ago

Offline Mad Matt
Mad Matt Avatar Member
65 Posts
United States
Reg. 2011-10-26
Log in to send this user a private message

Last updated: 2014-04-11 01:35am
ScreenSelectMaster.cpp line 674.

It's GetTweenTimeLeft, not GetTimeLeftInTween. oops.

Post #10 · Posted at 2014-04-21 11:16:09pm 8.1 years ago

Offline Wan
Wan Avatar Member
389 Posts
Chile
Reg. 2008-01-13
Log in to send this user a private messageTwitter: WannyTiggah
Steam: WannyTiggah
"I want to change my username =("

Last updated: 2014-04-21 11:17pm
YOU ARE GOD, MAD MATT.
It doesn't crash anymore, woohoo!

EDIT: Nonstop works, but Challenge (Oni) doesn't. I'm going to check why.
EDIT2: Ahh, sweet metrics.
________________________________________

Actually ScreenSelectCourse looks like this, for both Nonstop and Oni:

http://i.imgur.com/TnQRQ1g.jpg
I'm still on the hunt for an appropriate font for the course names

Post #11 · Posted at 2022-03-26 07:49:27pm 3.1 months ago

Offline Vixy45
Vixy45 Avatar Member
2 Posts
United States
Reg. 2022-03-17
Log in to send this user a private messageTwitter: OreovixGoogle+
Quote: Wan
Quote: Mad Matt
Quote: Wan
To not show the difficulty number in the list, any OpenITG build later than August 2011 is needed.
This is not strictly true. In normal 3.95 it is possible to override the text of any option row, although it has to be done in a difficult and convoluted way.

Quote: Wan
Now, I need help with the Difficulty selection screen. The screen uses Takuya's method so ScreenSelectMaster is used.
- First of all, if I pick either Nonstop or Challenge, the game crashes with an Access Violation. This happens from SM 3.95 onwards.
- The cursors behave weirdly. For example, if both players start in Beginner and Player 1 moves to Light, when Player 2 then moves to the right it SKIPS Player 1's cursor and goes straight to Standard. If Player 2 moves back to the left it lands on Light as it should.
If you want to send me a copy of the theme I can try to figure this out for you. Without seeing the code I can't offer much help.
Here you go, I didn't include the ending video for now (it's 127 MB big):

http://www.mediafire.com/download/wb3xj2ep7p95kfv/Parti_colekshon.7z

the download link seems to not be working Sad
OwO DDR (・∀・)

Post #12 · Posted at 2022-06-14 11:48:21pm 1.9 weeks ago

Offline 藍澤光
藍澤光 Avatar Member
4 Posts
Not Set
Reg. 2013-01-07
Log in to send this user a private messageWindows Live Messenger: aizawahikaru[at]live.jp

Last updated: 2022-06-14 11:56pm
This is ITG3 EXTREMEBig Grin
https://i.imgur.com/J6OHdc8.png
https://imgur.com/qnIERQB.png
Register Log In Back To Forums

0 User(s) Viewing This Thread (Past 15 Minutes)

©2006-2022 Zenius -I- vanisher.com -5th style- IIPrivacy Policy
Web Server: 9% · Database: 8% · Server Time: 2022-06-28 20:45:48
This page took 0.005 seconds to execute.
Theme: starlight · Language: englishuk
Reset Theme & Language